-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rate-limiting): do not set response headers if conf.hide_client_headers
is true
#13722
Conversation
`conf.hide_client_headers` is `true`
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13722-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13722-to-master-to-upstream
git checkout -b cherry-pick-13722-to-master-to-upstream
ancref=$(git merge-base 778fe086a1f46f44987dc17c984c3c0581996cbb 67de15a8f243531a279b4030b6a3d9a1e71d0d11)
git cherry-pick -x $ancref..67de15a8f243531a279b4030b6a3d9a1e71d0d11 |
Successfully created backport PR for |
Cherrypick in https://github.com/Kong/kong-ee/pull/10387 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.8.x
git worktree add -d .worktree/backport-13722-to-release/3.8.x origin/release/3.8.x
cd .worktree/backport-13722-to-release/3.8.x
git switch --create backport-13722-to-release/3.8.x
git cherry-pick -x cf403a731374c324b3dd9adef318ad5c848fee53 |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13722-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13722-to-master-to-upstream
git checkout -b cherry-pick-13722-to-master-to-upstream
ancref=$(git merge-base 778fe086a1f46f44987dc17c984c3c0581996cbb 67de15a8f243531a279b4030b6a3d9a1e71d0d11)
git cherry-pick -x $ancref..67de15a8f243531a279b4030b6a3d9a1e71d0d11 |
Please REBASE and MERGE
Summary
Fix #13715, we should not set the response header if
conf.hide_client_headers
istrue
.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
#13715, KAG-5492