Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rate-limiting): do not set response headers if conf.hide_client_headers is true #13722

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Sep 29, 2024

Please REBASE and MERGE

Summary

Fix #13715, we should not set the response header if conf.hide_client_headers is true.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

#13715, KAG-5492

@github-actions github-actions bot added plugins/rate-limiting cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 29, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP removed the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 29, 2024
@ADD-SP ADD-SP merged commit cf403a7 into master Oct 8, 2024
56 checks passed
@ADD-SP ADD-SP deleted the add_sp/fix-rl-plugins branch October 8, 2024 02:11
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13722-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13722-to-master-to-upstream
git checkout -b cherry-pick-13722-to-master-to-upstream
ancref=$(git merge-base 778fe086a1f46f44987dc17c984c3c0581996cbb 67de15a8f243531a279b4030b6a3d9a1e71d0d11)
git cherry-pick -x $ancref..67de15a8f243531a279b4030b6a3d9a1e71d0d11

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 8, 2024
@ADD-SP ADD-SP removed author/community PRs from the open-source community (not Kong Inc) incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Oct 8, 2024
@ADD-SP ADD-SP added backport release/3.8.x and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Oct 16, 2024
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
…headers` is `true` (#13722)

Fix #13715; we should not set the response header if `conf.hide_client_headers` is `true`.

(cherry picked from commit cf403a7)
@team-gateway-bot
Copy link
Collaborator

ADD-SP added a commit that referenced this pull request Oct 16, 2024
…headers` is `true` (#13759)

Fix #13715; we should not set the response header if `conf.hide_client_headers` is `true`.

Backport #13722

Co-authored-by: Qi <add_sp@outlook.com>
@kikito kikito added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 4, 2024
@kikito
Copy link
Member

kikito commented Nov 4, 2024

Cherrypick in https://github.com/Kong/kong-ee/pull/10387

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.8.x
git worktree add -d .worktree/backport-13722-to-release/3.8.x origin/release/3.8.x
cd .worktree/backport-13722-to-release/3.8.x
git switch --create backport-13722-to-release/3.8.x
git cherry-pick -x cf403a731374c324b3dd9adef318ad5c848fee53

@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13722-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13722-to-master-to-upstream
git checkout -b cherry-pick-13722-to-master-to-upstream
ancref=$(git merge-base 778fe086a1f46f44987dc17c984c3c0581996cbb 67de15a8f243531a279b4030b6a3d9a1e71d0d11)
git cherry-pick -x $ancref..67de15a8f243531a279b4030b6a3d9a1e71d0d11

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 4, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with rate-limiting plugin after 3.8.0.0 upgrade
6 participants