chore(release): use docker image to facilitate update-copyright step #13747
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
AndyZhang0707
commented
Oct 13, 2024
scripts/release-lib.sh
Outdated
| DIR=$(dirname "$0") | ||
| PDIR=$(dirname "$DIR") | ||
|
|
||
| if ! (docker build -t kong/update-copyright ${DIR} && docker run -v ${PDIR}:/workspace --rm kong/update-copyright) |
There was a problem hiding this comment.
We may consider publishing the docker image to reduce the build time in the future. But for now I've tried it several times docker always uses the local cached image thus it's not a big deal. @kikito any preferences?
AndyZhang0707
force-pushed
the
build/facilitate-update-copyright-script
branch
from
97e87c5
to
90a380e
Compare
team-gateway-bot
added
the
author/community
Oyami-Srk
reviewed
Oct 14, 2024
…tainer with all necessary dependencies
AndyZhang0707
force-pushed
the
build/facilitate-update-copyright-script
branch
from
90a380e
to
73a0a81
Compare
kikito
approved these changes
Oct 15, 2024
Oyami-Srk
approved these changes
Oct 16, 2024
|
Successfully created cherry-pick PR for |
|
We don't need cherrypicking this into kong-ee, there's a different process there for copyright handling |
kikito
removed
the
cherry-pick kong-ee
3 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was not easy to install and figure out all the dependencies for the update-copyright script. This PR aims to install all the required dependencies into a docker image and use it to execute the update-copyright script.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-5297
Fix #[issue number]