Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/otel metrics #13762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SuzyWangIBMer
Copy link

Summary

Support sending OTEL metrics using KONG

This pr grabs Prometheus metrics and translate to OTLP format.

The metrics are protobuf-serialized and sent to the endpoint
configured in the OpenTelemetry plugin's config.metrics_endpoint field.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

N/A

Discussion thread: #13620

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 16, 2024
@samugi samugi self-requested a review October 17, 2024 08:13
@samugi
Copy link
Member

samugi commented Oct 21, 2024

Hello @SuzyWangIBMer and thank you so much for your contribution.

As discussed privately, there are ongoing efforts to support native OTel metrics in Kong in a way that is highly optimized, to reduce performance impact to the minimum. Because of that, I would propose closing this pull request, which represents a valid workaround you may want to continue using until metrics are officially supported by the OpenTelemetry plugin.

Thanks again for sharing this approach, let me know in case of any doubts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering plugins/opentelemetry schema-change-noteworthy size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants