Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.8.x] fix(aws-lambda): add null handling for multiValueHeaders #13796

Open
wants to merge 1 commit into
base: release/3.8.x
Choose a base branch
from
Open

[backport -> release/3.8.x] fix(aws-lambda): add null handling for multiValueHeaders #13796

wants to merge 1 commit into from
+47 −4

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.8.x, triggered by a label in #13533.

Original description

Summary

A small PR for adding a null handling code for the multiValueHeaders field. Also contains a small refactor to put isBase64Encode check into the validate function to keep consistency with other fields

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

FTI-6168

@team-gateway-bot team-gateway-bot added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/aws-lambda size/M labels Oct 28, 2024
@team-gateway-bot team-gateway-bot mentioned this pull request Oct 28, 2024
Merged
3 tasks
@windmgc
fix(aws-lambda): add null handling for multiValueHeaders (#13533)
13cf116 
A small PR for adding a null handling code for the multiValueHeaders field. Also contains a small refactor to put isBase64Encode check into the validate function to keep consistency with other fields

FTI-6168

(cherry picked from commit 50c57c8)
@windmgc windmgc force-pushed the backport-13533-to-release/3.8.x branch from f151d73 to 13cf116 Compare October 31, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsinre outsinre outsinre left review comments

@catbro666 catbro666 catbro666 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@windmgc windmgc

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/aws-lambda size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@team-gateway-bot @outsinre @catbro666 @windmgc