Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(incremental sync): added comment for 2 times do_sync #13801

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix(incremental sync): added comment for 2 times do_sync #13801

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
930a240
fix(incremental sync): added comment for 2 times do_sync
chobits Oct 29, 2024
f3b64e6
fix(incremental sync): added comment for 2 times do_sync (2)
chobits Oct 29, 2024
11a6aa2
fix(incremental sync): added comment for 2 times do_sync (3)
chobits Oct 29, 2024
8da7a9d
Update rpc.lua
dndx Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kong/clustering/services/sync/rpc.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,10 @@ local function sync_handler(premature)
end

local res, err = concurrency.with_worker_mutex(SYNC_MUTEX_OPTS, function()
-- here must be 2 times
-- must be 2 times for retrieving the latest delta version and latest deltas
--
-- The second call to do_sync() on `kong.sync.v2.get_delta` retrieves the
-- latest delta version directly, without requiring additional API calls.
chobits marked this conversation as resolved.
Show resolved Hide resolved
for _ = 1, 2 do
local ok, err = do_sync()
if not ok then
Expand Down
Loading