fix response rate limit check condition #13811
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes the kong response rate limiting plugin where the limit usage value can go in negative if there are parallel requests.
For example, if below limits are configured:
{ "limit": { "second": null, "minute": 1, "hour": null, "day": null, "month": null, "year": null } }
and we send 4-5 parallel requests then the usage counter will go in negative and skip the zero condition check and by pass the rate limits.
Similar to header_filter.lua where we check for negative value(lv.remaining <= 0), we need to do the same in access.lua.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]