fix(incremental sync): fixed ws_id processing in _set_entity_for_txn #13816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
cherry-pick kong-ee
team-gateway-bot
added
the
author/community
chobits
removed
the
author/community
chronolaw
reviewed
Oct 31, 2024
team-gateway-bot
added
the
author/community
chronolaw
approved these changes
Oct 31, 2024
|
wait for the kong ee ci to become green for this pr's cherry-picked version |
chronolaw
force-pushed
the
refactor/tuning_inc_sync
branch
from
f35c3d3
to
63c17e2
Compare
chobits
force-pushed
the
fix/incr_sync_kag_5710
branch
from
b49c9ab
to
6813314
Compare
github-actions
bot
added
core/db/migrations
core/clustering
schema-change-noteworthy
labels
chobits
force-pushed
the
fix/incr_sync_kag_5710
branch
from
6813314
to
3b97f0e
Compare
bungle
pushed a commit
that referenced
this pull request
Nov 1, 2024
* fix(db): pagesize must not be less than 2 * fix(db): set global key in lmdb * fix(db): use request_aware_table correctly * fix(dbless): get default workspace correctly * fix(clustering): check latest_version and d.ws_id * fix(clustering): fix dp do_sync() * fix(clustering):fix declarative export sync * fix(clustering):check latest_version == ngx_null in CP * fix(clustering): inc sync add ws (#13790) * fix(clustering/sync): set ws_id in do_sync() * fix(clustering): delta version is null (#13789) * fix(clustering/sync): delta.version may be null * refactor(clustering): change sync data structure (#13794) * fix(incremental sync): added comment for 2 times do_sync (#13801) * fix(incremental sync): fix cache_key handling for select_by_cache_key (#13815) * fix(incremental sync): fix cache_key handling for select_by_cache_key * refactor(dbless): clean logic of select_by_field (#13817) * refactor(dbless): clean logic of selec_by_field * fix(incremental sync): fixed ws_id processing in _set_entity_for_txn (#13816) --------- Co-authored-by: Xiaochen Wang <wangxiaochen0@gmail.com> Co-authored-by: Datong Sun <datong.sun@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this loop of _set_entity_for_txn, the ws_id has been modifed to default ws_id, but the following logic or entity will use this modified ws_id even though they are unreleated to previous modified ws_id.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5710