refactor(clustering/rpc): code clean of full sync in rpc #13823
+24
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
chronolaw
changed the title
team-gateway-bot
added
the
author/community
chobits
approved these changes
Nov 4, 2024
team-eng-enablement
removed
the
author/community
This reverts commit 4632d09.
chronolaw
force-pushed
the
refactor/clean_rpc_full_sync
branch
from
0ea3060
to
3fdffb3
Compare
StarlightIbuki
approved these changes
Nov 5, 2024
| end | ||
|
|
||
| -- wipe dp lmdb, full sync | ||
| return { default = { deltas = deltas, wipe = true, }, } |
There was a problem hiding this comment.
Suggested change
| return { default = { deltas = deltas, wipe = true, }, } | |
| return gen_delta_result(deltas, true) |
Otherwise remove the function above
There was a problem hiding this comment.
Talked offline, it is not a blocker.
| local function gen_delta_result(res, wipe) | ||
| return { default = { deltas = res, wipe = wipe, }, } | ||
|
|
||
| local function full_sync_result() |
There was a problem hiding this comment.
Suggested change
| local function full_sync_result() | |
| local function full_sync() |
The name is not very proper
There was a problem hiding this comment.
Talked offline, it is not a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5728
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]