refactor(clustering/rpc): dp does not need concentrator #13829
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
This reverts commit 1f9d54f.
dndx
requested changes
Nov 5, 2024
No, in DP it should always return Adding an assert to ensure it. |
StarlightIbuki
approved these changes
Nov 5, 2024
| self.concentrator = concentrator.new(self, kong.db) | ||
| if conf.role == "control_plane" then | ||
| self.concentrator = require("kong.clustering.rpc.concentrator").new(self, kong.db) | ||
| self.client_ips = {} -- store DP node's ip addr |
There was a problem hiding this comment.
What about make client_ips a part of concerntrator
There was a problem hiding this comment.
Not sure about it, but I think collecting ip addresses is not the responsibility of concentrator.
|
|
||
| if self.concentrator then | ||
| self.client_ips[node_id] = nil | ||
| assert(self.concentrator:_enqueue_unsubscribe(node_id)) |
There was a problem hiding this comment.
and so it can be a part of unsubscribe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5730
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]