-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update router default #4934
Conversation
dafe9ac
to
b4168d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4934 +/- ##
=======================================
- Coverage 77.6% 75.3% -2.3%
=======================================
Files 167 167
Lines 18709 18709
=======================================
- Hits 14527 14102 -425
- Misses 3345 3782 +437
+ Partials 837 825 -12 ☔ View full report in Codecov by Sentry. |
Manifest updates as written wouldn't work since they use the same envvar across DB-less and DB-backed. I need to figure out how to either replace that (complicated by the |
bdf95ba
to
d16767a
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6628345628 |
Alright, with the guidance to have DB-less default to expressions and DB-backed to traditional_compatible, revised kustomize bits, and a revised matrix, I think this is now ready. |
337d7ff
to
cd20d31
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6654763042 |
…t all Kong Gateway flavors
9d1dba6
to
d04bd85
Compare
What this PR does / why we need it:
Changes the router default to
expressions
.Which issue this PR fixes:
Part of #4719
Special notes for your reviewer:
See #3693 (comment) for areas of the code that interact with this setting but were not updated, usually because they handle any allowed router value.
Per other commentary in that issue, we had an open question on whether to use
expressions
ortraditional_compatible
. It looked like we were proceeding withexpressions
elsewhere, so I went with that. Opening this PR to sorta prod that decision forward.Either way, we update the same locations, so if we do want to use
traditional_compatible
instead, it's easy enough to update the diff.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR