fix custom extensions not loading because of eager rebuilds (#182)

* fix custom extensions not loading because of eager rebuilds * add changeset * prettier * add changeset * prettier
KonnorRogers · May 18, 2024 · c64173a · c64173a
1 parent 195f28e
commit c64173a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/.changeset/itchy-wombats-hide.md b/.changeset/itchy-wombats-hide.md
@@ -0,0 +1,5 @@
+---
+"rhino-editor": patch
+---
+
+Fixed a bug in the update lifecycles of RhinoEditor causing rebuilds to happen too frequently
diff --git a/src/exports/elements/tip-tap-editor-base.ts b/src/exports/elements/tip-tap-editor-base.ts
@@ -312,10 +312,6 @@ export class TipTapEditorBase extends BaseElement {
       this.classList.add("rhino-editor");
     }
 
-    if (changedProperties.has("serializer")) {
-      this.updateInputElementValue();
-    }
-
     super.willUpdate(changedProperties);
   }
 
@@ -328,12 +324,17 @@ export class TipTapEditorBase extends BaseElement {
 
     if (
       changedProperties.has("extensions") ||
+      changedProperties.has("serializer") ||
       changedProperties.has("starterKitOptions") ||
       changedProperties.has("translations")
     ) {
       this.rebuildEditor();
     }
 
+    if (changedProperties.has("serializer")) {
+      this.updateInputElementValue();
+    }
+
     super.updated(changedProperties);
   }
 

diff --git a/src/exports/elements/tip-tap-editor.ts b/src/exports/elements/tip-tap-editor.ts
@@ -148,7 +148,8 @@ export class TipTapEditor extends TipTapEditorBase {
     this.addEventListener("keydown", this.handleKeyboardDialogToggle);
   }
 
-  protected willUpdate(changedProperties: PropertyValues<this>): void {
+  protected updated(changedProperties: PropertyValues<this>): void {
+    const returnValue = super.updated(changedProperties);
     if (changedProperties.has("translations")) {
       const { rhinoAttachment, rhinoPlaceholder } = this.starterKitOptions;
       let shouldRebuild = Boolean(rhinoAttachment || rhinoPlaceholder);
@@ -168,7 +169,8 @@ export class TipTapEditor extends TipTapEditorBase {
         this.rebuildEditor();
       }
     }
-    return super.willUpdate(changedProperties);
+
+    return returnValue;
   }
 
   /**