test: VFX source-inspection contracts + Star Wars vanilla bundle cleanup#49
test: VFX source-inspection contracts + Star Wars vanilla bundle cleanup#49KooshaPari merged 5 commits intomainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (68)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the project's stability and maintainability by overhauling the VFX testing infrastructure and cleaning up legacy assets in the Star Wars mod. The refactored VFX tests now validate core contracts directly from source, making them more robust and efficient. Concurrently, the removal of placeholder asset bundles from the Star Wars mod ensures a cleaner and more accurate representation of in-game models. Additionally, critical security vulnerabilities have been patched, and several other fixes and enhancements have been integrated. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the VFX integration tests to a source-inspection model to remove runtime dependencies and cleans up placeholder bundles in the Star Wars pack. While the cleanup is good, I have two points of feedback. First, there's a duplicated section in the CHANGELOG.md that should be removed for clarity. Second, and more importantly, the new testing strategy for VFX, while meeting its goal of removing runtime dependencies, significantly reduces test quality and maintainability by relying on brittle string matching of source code. I've left a detailed comment suggesting a more robust unit testing approach that would still avoid runtime dependencies.
Release highlights: - fix(security): SixLabors.ImageSharp 3.0.2→3.1.11 (7 CVEs) - fix(ui): DebugPanel/ModMenuPanel alpha flicker on Show() - fix(sdk): RegisterItems<T> no longer swallows registration failures - test: LODCalculationTests + VFXPoolLogicTests; Phase 3A/3B expansions - chore: all 17 lock files synced; pack ID + integration test fixes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Primitive placeholder bundles (<50KB capsule/cube/sphere geometry) deleted. ContentLoader skips missing bundles → units use vanilla game appearance. 8 units keep real 3D models: Republic: clone trooper, clone heavy, clone medic CIS: B1 droid, B2 droid, commando droid, sniper droid, clone barracks Remaining 42 entries fall back to vanilla until PRO Sketchfab token downloads the queued UIDs from asset_pipeline.yaml v0_9_0_future. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
KooshaPari
force-pushed
the
codex/refactor-ci-safe-tests
branch
from
d0bec57 to
758a9c6
Compare
1 participant
Summary
91b6b11)d0bec57)Test plan
🤖 Generated with Claude Code