feature: add support for the geocentric Earth radius#256
Open
msheby wants to merge 2 commits intoKosherJava:masterfrom
Open
feature: add support for the geocentric Earth radius#256msheby wants to merge 2 commits intoKosherJava:masterfrom
msheby wants to merge 2 commits intoKosherJava:masterfrom
Conversation
Owner
|
@msheby , thank you very much for the PR. You may have noticed that there is a 3-0-modernization branch, and that is currently keeping me busy. I hope to look at this in a few weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use WGS84 ellipsoid for latitude-dependent Earth radius in elevation adjustments
Add getGeocentricRadius() to AstronomicalCalculator that calculates
Earth's radius based on observer latitude using WGS84 ellipsoid.
ZmanimCalendar now uses this when elevation adjustments are enabled.
Earth's radius varies from 6378.137 km at equator to 6356.752 km at
poles. Using a fixed 6356.9 km introduced systematic errors of ~14 km
at mid-latitudes, translating to 1-2 seconds in sunset calculations.
Reference: WGS84 ellipsoid parameters (NGA Technical Report 8350.2)