Change re for finding PAE.png plots #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_report dies when trying to convert jupyter notebook to html. To fix that we can adjust this regular expression for finding PAE.png plots: https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/analysis_pipeline/utils.py#L17 to the file names produced by AP: https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/folding_backend/alphafold_backend.py#L595
|
This is a really good catch |
dingquanyu
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_report dies when trying to convert jupyter notebook to html.
https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/analysis_pipeline/create_notebook.py#L71
To fix that we can adjust this regular expression for finding PAE.png plots: https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/analysis_pipeline/utils.py#L17
to the *.png file names produced by AP:
https://github.com/KosinskiLab/AlphaPulldown/blob/main/alphapulldown/folding_backend/alphafold_backend.py#L595