Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the compare_and_replace function tests #122

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

tarunkumar2005
Copy link
Contributor

Description

Created the compare_and_replace function tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Tests update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

@Kota-Karthik @techy4shri Please check this PR and merge it and assign this to me and put relevant labels such as gssoc 2024 ext, hacktoberfest and level.

Please note 1 test was not successful it is deleting the file :-

FAILED tests/allFileMetadata_compare_and_replace.py::TestAllFileMetadata::test_compare_and_replace_correct_file_removed - AssertionError: assert False

Copy link
Owner

@Kota-Karthik Kota-Karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunkumar2005
can you fix workflows?
also please fix tests, and please add screenshots

@tarunkumar2005
Copy link
Contributor Author

@Kota-Karthik @techy4shri Done the changes and here is the screenshot :-

image

Please review it now.

Copy link
Contributor Author

@tarunkumar2005 tarunkumar2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changes

@Kota-Karthik
Copy link
Owner

@tarunkumar2005
LGTM!

@Kota-Karthik Kota-Karthik merged commit 486a67a into Kota-Karthik:main Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Unit Tests for compare_and_replace Method
3 participants