updated Dry Run feature #128
Conversation
There was a problem hiding this comment.
@adityakalburgi I would suggest you follow the PR guidelines. Fill the template I have given here. It is needed so as to facilitate point assignment and any future review.
Also, please maintain a clean commit history by squashing all the commits. You can do so by follwowing the steps below:
git fetch origingit rebase -i HEAD~5squash <commit message>git push --force
Wait for review from Karthik afterwards.
There was a problem hiding this comment.
@adityakalburgi
please follow the PR template
only then any changes would be reviewed
|
Waiting for a response @adityakalburgi. Failure in responding within 24 hours will lead to me closing your PR. |
Hi i am soo updating the PR thank you.. |
|
@adityakalburgi |
|
@adityakalburgi update? |
Ok sure will do it soon... |
hi @techy4shri i have sync my fork please have a look thank you! |
|
@adityakalburgi will do soon. Wait for review from Karthik. |
|
@Kota-Karthik review ra pls |
techy4shri
added
enhancement
There was a problem hiding this comment.
@adityakalburgi
Your pr still removes most of the code
like logging and other interactive cli code
please fix it!
| from twinTrim.dataStructures.fileFilter import FileFilter | ||
|
|
||
| # Setting up logging configuration | ||
| logging.basicConfig ( |
There was a problem hiding this comment.
@adityakalburgi
check this
your changes removes the logging part and interactive cli part totally
This is not cause you removed them , but because you havent pulled chaanges
updated the logging error
|
hi @Kota-Karthik i have updated my PR! |
|
I will say to close this PR, delete your fork of TwinTrim, Then refork the repo, do your changes on the new fork and then submit a new PR This PR now is looking dirty with so many redundant merges. |
|
Squash the commits and make the commit history clean please or raise a new PR. |
|
@adityakalburgi |
I will create a new PR so you can close this one |
Hi @techy4shri, @Kota-Karthik
Thank you for your feedback! I apologize for not following the PR template initially. I’m currently updating the PR with the required information.
Description
Updated the README.md to clarify project setup instructions.
Added a dry run feature in flags.py, which will display the files that would be deleted without actually removing them. This allows users to review the potential deletions before making any changes.
Type of change
Please delete options that are not relevant.
Checklist
Screenshots (if applicable)