Skip to content

new feature additions #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

eeshwar369
Copy link

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.

  • Fixes #(issue number)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Tests update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

Add screenshots to help explain the changes (if necessary).

@eeshwar369
Copy link
Author

Features added:-
Thread Safety: Access to the normalStore is protected with a normalStore_lock to ensure that updates are thread-safe.
Duplicate Count: Each file hash tracks how many times the same file (with the same hash) has been added.
Timestamps: A timestamp is stored when the file is first added, allowing you to track when the file entered the system.
File Removal: Added a remove_file function that removes the file from the metadata and deletes the entry if no files are left.

@techy4shri
Copy link
Collaborator

techy4shri commented Oct 22, 2024

Got quite a number of rule violations there, don't we?

  1. Contribution Guidelines violation 1: raising a PR without raising an issue first
  2. Contribution Guidelines violation 2: raisign a PR without being assigned an issue
  3. Contribution Guidelines violation 3: not following PR Template
  4. Contribution Guidelines violation 4: Ignoring the code of conduct
  5. Redundant conributions.
  6. GSSoC guidelines violation.
    This concludes a count of 6 violations, which means:
    With these six infractions, effective immediately, you are barred from contributing to this repository, barring express authorization from @Kota-Karthik. Any further attempts will be nullified, and persistent misconduct will result in severe repercussions.

@techy4shri techy4shri closed this Oct 22, 2024
Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant code with multiple rule violation.

@techy4shri techy4shri added invalid This doesn't seem right wontfix This will not be worked on REJECTED Pull request rejected labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right REJECTED Pull request rejected wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants