-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added function for add_or_update_file #149
Conversation
I'm doing this under gssoc-ext so can you add the label |
@Sai-ganesh-0004 resolve the issues with your PR. I can see one of the test cases has failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sai-ganesh-0004
You were not supposed to make any changes in twinTrim/dataStructures/allFileMetadata.py
whatever changes you have made in twinTrim/dataStructures/allFileMetadata.py
, please revert them back
other than that tests look good
but workflows are failing
please fix it!
im using 3.10.8 so can you change the version in |
should i change the version and push the changes again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted the changes and made the code so that it is compatible with Python version 3.8
@Sai-ganesh-0004 it's not the python version which causes issues. 3.8 is min level of version which should be used for compatibility. Next time, make sure to follow dependencies installation instructions as stated in Readme to avoid such issues! |
ok Sorry for the inconvenience. Are there any other issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sai-ganesh-0004
can you just squash all of your commits into one ?
We would just prefer and appreciate a cleaner commit history !
as soon as that is done , we will be merging this PR!
@Sai-ganesh-0004 why delete? |
created another pr i couldn't squash all the commits into one |
Since you deleted it, we cannot do anything about it but here:
|
Description
This PR adds unit tests to verify the functionality of the
add_or_update_file
function inallFileMetadata.py
. These tests ensure that:The tests follow the project’s guidelines and use
pytest
for implementation.add_or_update_file
Function #4Type of change
Checklist
Screenshots (if applicable)