Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added normalised expected path to tackle windows specific error. #158

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

techy4shri
Copy link
Collaborator

Description

Used path normalization of OS lib in Python os.path.normpath() to normalize the path by converting it into the correct format based on the operating system (backslashes for Windows, forward slashes for Unix-based systems).

This ensures both the expected and actual values in the test are comparable, no matter which platform the test is being run on and all tests pass without any error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

BEFORE:
Screenshot 2024-10-27 195331

AFTER:
Screenshot 2024-10-28 164120

Copy link
Owner

@Kota-Karthik Kota-Karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techy4shri
LGTM!

@Kota-Karthik Kota-Karthik merged commit 1e361b3 into Kota-Karthik:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Assertion Error in test_flagController.py
2 participants