Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for find_duplicates #164

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Sai-ganesh-0004
Copy link
Contributor

@Sai-ganesh-0004 Sai-ganesh-0004 commented Oct 30, 2024

Description

This update introduces unit tests for the find_duplicates function in the twinTrim.flagController module. The tests cover various scenarios, including finding duplicate files, handling directories with no files, and proper filtering of files. These tests ensure the robustness of the duplicate detection functionality by validating its behavior in different contexts.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Tests update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

image

@Sai-ganesh-0004
Copy link
Contributor Author

@techy4shri
can you add labels for this pr

@Sai-ganesh-0004
Copy link
Contributor Author

Want me to add anything else I will add

@Kota-Karthik
Copy link
Owner

@Sai-ganesh-0004
I see no problems with the code , but let @techy4shri submit her review
will merge it ,if she doesn't request any changes!

@Sai-ganesh-0004
Copy link
Contributor Author

@techy4shri Please review

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working fantastic, I approve @Kota-Karthik !
@Sai-ganesh-0004 good work.

@techy4shri techy4shri merged commit 39fb531 into Kota-Karthik:main Nov 1, 2024
2 checks passed
@Sai-ganesh-0004
Copy link
Contributor Author

Sai-ganesh-0004 commented Nov 2, 2024

@techy4shri can you add gssoc-ext label for this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Unit Tests for find_duplicates Function
3 participants