Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flags.py #59

Closed
wants to merge 1 commit into from
Closed

Update flags.py #59

wants to merge 1 commit into from

Conversation

vid0326
Copy link

@vid0326 vid0326 commented Oct 3, 2024

Description

-> Moved utility functions (print_info, print_success, print_warning, print_error, handle_and_remove, parse_size, get_file_hash) from main.py to utils.py to keep the code modular and reusable.

->Updated imports in main.py to reflect the new structure.

->Tested the new structure and confirmed that the code works as expected.

->Fixed the issue regarding the missing reference to print_success in utils.py.

->Ensured that the code generates no new warnings and that unit tests (if any) pass successfully.

This PR addresses Issue #59, which relates to improving code organization by moving reusable utility functions into a separate module (utils.py).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Tests update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have maintained a clean commit history by using the necessary Git commands
  • I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

image

Add screenshots to help explain the changes (if necessary).

@Kota-Karthik
Copy link
Owner

@vid0326
its great
everything looks good
but can you just move these functions to utils.py and add screenshots to ensure the code works fine even after the changes

@vid0326
Copy link
Author

vid0326 commented Oct 3, 2024

Screenshot 2024-10-03 235228

@techy4shri
Copy link
Collaborator

@vid0326 Please fill the PR format properly to be given points properly. Add screenshot in the area provided andcheck the necessary boxes. Also mention the issue number so I can label this.

@vid0326
Copy link
Author

vid0326 commented Oct 4, 2024

issue number #59
Screenshot 2024-10-03 235228
updated flag.y utilis.py

@Kota-Karthik
Copy link
Owner

@vid0326
you didn't make any changes as per my review
please make necessary changes then the PR will be good to merge!

@techy4shri
Copy link
Collaborator

@vid0326 what we need in this PR is this:

  1. Move the updates you meade in the flags.py to utils.py
  2. Remove any changes made in the flags.py
  3. Commit those changes.
  4. Push the changes.
  5. Fill the PR template properly and tag us both.
  6. Please include screenshots and comment on your code properly to ensure we can review it easily.
    I hope I made things clear, if not feel free to ask on discord!

@techy4shri techy4shri closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants