Optimize color palette in CLI #93
Conversation
There was a problem hiding this comment.
@mienpham04 do not remove anything unless required. I see that the logging is removed and so it the dry run function.
Revert your changes, and only work on the solution you are assigned.
Your task is to add distinct colours to different texts which appears in the CLI while the package runs, not remove features others added.
Define a colour pallete for each type, implement it, write a good description in your PR how and where the changes are implemented and then request review again.
twinTrim/flags.py
Outdated
| @@ -24,10 +16,9 @@ | |||
| @click.option("--exclude", multiple=True, help="Files to exclude by name.") | |||
| @click.option("--label-color", default="yellow", type=str, help="Color of the label of progress bar.") | |||
| @click.option("--bar-color", default='#aaaaaa', type=str, help="Color of the progress bar.") | |||
| @click.option("--dry-run", is_flag=True, help="Simulate the process without deleting files.") | |||
There was a problem hiding this comment.
Why did you remove this line? Do not remove anything without any reason, and if you do remove something, always comment the reason.
| @@ -1,20 +1,12 @@ | |||
| import os | |||
| import click | |||
| import time | |||
| import logging | |||
There was a problem hiding this comment.
why did you remove logging??
| @@ -8,7 +8,7 @@ | |||
| def handle_and_remove(filepath): | |||
| try: | |||
| os.remove(filepath) | |||
| click.echo(click.style(f"Deleted: {filepath}", fg='green')) | |||
| click.echo(click.style(f"Deleted: {filepath}")) | |||
There was a problem hiding this comment.
do not change the utils file unless needed. Your task issue mentioned falgs.py only.
|
@mienpham04 You also have merge conflicts |
techy4shri
added
the
changes requested
|
Closing this pull request due to unresponsiveness of the contributor. |
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
Resolve inconsistent color palette in CLI
Please delete options that are not relevant.
Checklist
Screenshots (if applicable)
Add screenshots to help explain the changes (if necessary).
