KGP IT: Support testing AGP with Kotlin-built-in #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for testing AGP projects that use kotlin-built-in. I converted the existing `requiredAgpMajorVersions` check into a unit test. This will help verify that TestedVersionsSource doesn't accidentally filter out any of the tested versions. It could be a bit of a pain to maintain? But this test is quick and easy, and if it prevents a bug where a version is accidentally excluded, it'd be worth it. (We could use test coverage support on TeamCity? But I'm not sure how to add that, and it could be fragile or easy to ignore?) Currently there are no test-projects for kotlin-built-in. These will be added in #4295.
adam-enko
added
the
runner: Gradle plugin
Collaborator
|
TBH, for me it looks like complicating our Android-related IT infrastructure even more... |
Member
Author
if it helps, we can remove the conditional logic when we stop supporting AGP <9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for testing AGP projects that use kotlin-built-in.
I converted the existing
requiredAgpMajorVersionscheck into a unit test. This will help verify that TestedVersionsSource doesn't accidentally filter out any of the tested versions. It could be a bit of a pain to maintain? But this test is quick and easy, and if it prevents a bug where a version is accidentally excluded, it'd be worth it. (We could use test coverage support on TeamCity? But I'm not sure how to add that, and it could be fragile or easy to ignore?)Currently there are no test-projects for kotlin-built-in. These will be added in #4295.