Skip to content

Conversation

Mr3zee
Copy link
Member

@Mr3zee Mr3zee commented Sep 16, 2025

Subsystem
Tests

Problem Description
Ktor was lacking closure tests for transport

@Mr3zee Mr3zee requested a review from e5l September 16, 2025 17:15
@Mr3zee Mr3zee self-assigned this Sep 16, 2025
@Mr3zee Mr3zee added the housekeeping Some miscellaneous code base changes, tests, etc. label Sep 16, 2025
@Mr3zee Mr3zee changed the title Added Ktor closure tests Added Ktor closure tests and Cancellation tests, + minor fixes Sep 17, 2025
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mr3zee, thank you for the PR.
In general, it is good to test Ktor and transport API separately, but having an end-to-end test is also a generally good idea.
lgtm

Base automatically changed from 2.2.20 to development September 30, 2025 09:04
@Mr3zee Mr3zee merged commit 5b983f5 into development Sep 30, 2025
3 checks passed
@Mr3zee Mr3zee deleted the leak branch September 30, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Some miscellaneous code base changes, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants