Skip to content

Conversation

Mr3zee
Copy link
Member

@Mr3zee Mr3zee commented Sep 29, 2025

Subsystem
Protoc-gen

Problem Description
Out generated messages don't have any hashCode, equals and toString

Solution
Make pb-specific implementations of these functions

@Mr3zee Mr3zee requested a review from Jozott00 September 29, 2025 11:14
@Mr3zee Mr3zee self-assigned this Sep 29, 2025
@Mr3zee Mr3zee added the feature New feature or request label Sep 29, 2025
Copy link

@Jozott00 Jozott00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor suggestion

Base automatically changed from pb-options to grpc-common September 30, 2025 09:34
@Mr3zee Mr3zee force-pushed the pb-hashcode-equals-tostring branch from 92797d1 to 76409fe Compare September 30, 2025 09:34
@Mr3zee Mr3zee merged commit 8f84391 into grpc-common Sep 30, 2025
5 of 6 checks passed
@Mr3zee Mr3zee deleted the pb-hashcode-equals-tostring branch September 30, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants