Skip to content

Added full KMP support for the Gradle Plugin #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: grpc-common
Choose a base branch
from
Open

Added full KMP support for the Gradle Plugin #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7b59c4d
Added full KMP support with proto source sets hierarchy and better pl…
Mr3zee Nov 19, 2025
0c1f294
Added testing with multiple Gradle versions
Mr3zee Nov 19, 2025
5be747e
Added execution task order test for KMP
Mr3zee Nov 20, 2025
5e72797
Added caching task test for KMP
Mr3zee Nov 21, 2025
85f851b
Added custom tasks back and BufTasks container with tests
Mr3zee Nov 24, 2025
642f96d
dumpAbi
Mr3zee Nov 24, 2025
f885232
fix tasks dependencies
Mr3zee Nov 24, 2025
da8b10a
Added coping test
Mr3zee Nov 24, 2025
ca8ef58
Added missing docs and improved BufTasks implementation
Mr3zee Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gradle-conventions/src/main/kotlin/conventions-jvm.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ java {
withSourcesJar()
}

configureJavaCompatibility(8)
if (project.name != "gradle-plugin") {
configureJavaCompatibility(8)
}

configureKotlinCompatibility("2.0.0")

kotlin {
Expand Down
30 changes: 19 additions & 11 deletions gradle-conventions/src/main/kotlin/util/other/generateSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,28 @@ fun Project.generateSource(
text: String,
chooseSourceSet: NamedDomainObjectContainer<KotlinSourceSet>.() -> NamedDomainObjectProvider<KotlinSourceSet>,
) {
val sourcesDir = File(project.layout.buildDirectory.asFile.get(), "generated-sources/kotlin")

val generatePluginVersionTask =
tasks.register<GenerateSourceTask>("generateSources_$name", name, text, sourcesDir)

withKotlinJvmExtension {
chooseSourceSet(sourceSets).configure {
kotlin.srcDir(generatePluginVersionTask.map { it.sourcesDir })
}
generateSource(sourceSets, name, text, chooseSourceSet)
}

withKotlinKmpExtension {
chooseSourceSet(sourceSets).configure {
kotlin.srcDir(generatePluginVersionTask.map { it.sourcesDir })
}
generateSource(sourceSets, name, text, chooseSourceSet)
}
}

private fun Project.generateSource(
sourceSets: NamedDomainObjectContainer<KotlinSourceSet>,
name: String,
text: String,
chooseSourceSet: NamedDomainObjectContainer<KotlinSourceSet>.() -> NamedDomainObjectProvider<KotlinSourceSet>,
) {
val sourceSet = chooseSourceSet(sourceSets)
val sourcesDir = File(project.layout.buildDirectory.asFile.get(), "generated-sources/kotlin/${sourceSet.name}")

val generatePluginVersionTask =
tasks.register<GenerateSourceTask>("generateSources_$name", name, text, sourcesDir)

sourceSet.configure {
kotlin.srcDir(generatePluginVersionTask.map { it.sourcesDir })
}
}
109 changes: 67 additions & 42 deletions gradle-plugin/api/gradle-plugin.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ public abstract interface annotation class kotlinx/rpc/RpcDangerousApi : java/la
}

public class kotlinx/rpc/RpcExtension {
public fun <init> (Lorg/gradle/api/model/ObjectFactory;Lorg/gradle/api/Project;)V
public final fun getAnnotationTypeSafetyEnabled ()Lorg/gradle/api/provider/Provider;
public final fun getProtoc ()Lkotlinx/rpc/protoc/ProtocExtension;
public final fun getProtoc ()Lorg/gradle/api/provider/Provider;
public final fun getStrict ()Lkotlinx/rpc/RpcStrictModeExtension;
public final fun protoc (Lorg/gradle/api/Action;)V
public static synthetic fun protoc$default (Lkotlinx/rpc/RpcExtension;Lorg/gradle/api/Action;ILjava/lang/Object;)V
Expand All @@ -27,7 +26,6 @@ public final class kotlinx/rpc/RpcStrictMode : java/lang/Enum {
}

public class kotlinx/rpc/RpcStrictModeExtension {
public fun <init> (Lorg/gradle/api/model/ObjectFactory;)V
public final fun getFields ()Lorg/gradle/api/provider/Property;
public final fun getNestedFlow ()Lorg/gradle/api/provider/Property;
public final fun getNotTopLevelServerFlow ()Lorg/gradle/api/provider/Property;
Expand All @@ -43,13 +41,11 @@ public final class kotlinx/rpc/VersionsKt {
}

public class kotlinx/rpc/buf/BufCommentsExtension {
public fun <init> (Lorg/gradle/api/Project;)V
public final fun getCopyComments ()Lorg/gradle/api/provider/Property;
public final fun getIncludeFileLevelComments ()Lorg/gradle/api/provider/Property;
}

public class kotlinx/rpc/buf/BufExtension {
public fun <init> (Lorg/gradle/api/model/ObjectFactory;)V
public final fun generate (Lorg/gradle/api/Action;)V
public final fun getConfigFile ()Lorg/gradle/api/provider/Property;
public final fun getGenerate ()Lkotlinx/rpc/buf/BufGenerateExtension;
Expand All @@ -70,7 +66,7 @@ public final class kotlinx/rpc/buf/BufExtension$LogFormat : java/lang/Enum {
}

public class kotlinx/rpc/buf/BufGenerateExtension {
public fun <init> (Lorg/gradle/api/Project;)V
public final fun allTasks ()Lkotlinx/rpc/buf/tasks/BufTasks;
public final fun comments (Lorg/gradle/api/Action;)V
public final fun getComments ()Lkotlinx/rpc/buf/BufCommentsExtension;
public final fun getErrorFormat ()Lorg/gradle/api/provider/Property;
Expand All @@ -92,13 +88,9 @@ public final class kotlinx/rpc/buf/BufGenerateExtension$ErrorFormat : java/lang/
}

public class kotlinx/rpc/buf/BufTasksExtension {
public fun <init> (Lorg/gradle/api/Project;)V
public final fun registerWorkspaceTask (Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/Action;)Lkotlinx/rpc/buf/BufTasksExtension$TaskProvider;
}

public abstract interface class kotlinx/rpc/buf/BufTasksExtension$TaskProvider {
public abstract fun getMainTask ()Lorg/gradle/api/provider/Provider;
public abstract fun getTestTask ()Lorg/gradle/api/provider/Provider;
public final fun all ()Lkotlinx/rpc/buf/tasks/BufAllTasks;
public final fun registerWorkspaceTask (Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/Action;)Lkotlinx/rpc/buf/tasks/BufTasks;
public static synthetic fun registerWorkspaceTask$default (Lkotlinx/rpc/buf/BufTasksExtension;Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/Action;ILjava/lang/Object;)Lkotlinx/rpc/buf/tasks/BufTasks;
}

public final class kotlinx/rpc/buf/ConstsKt {
Expand All @@ -107,24 +99,39 @@ public final class kotlinx/rpc/buf/ConstsKt {
public static final field BUF_YAML Ljava/lang/String;
}

public abstract interface class kotlinx/rpc/buf/tasks/BufAllTasks : kotlinx/rpc/buf/tasks/BufTasks {
public abstract fun matchingType (Lkotlin/reflect/KClass;)Lkotlinx/rpc/buf/tasks/BufTasks;
}

public abstract class kotlinx/rpc/buf/tasks/BufExecTask : org/gradle/api/DefaultTask {
public fun <init> ()V
public fun <init> (Lkotlinx/rpc/buf/tasks/BufExecTask$Properties;)V
public abstract fun getArgs ()Lorg/gradle/api/provider/ListProperty;
public abstract fun getBufTimeoutInWholeSeconds ()Lorg/gradle/api/provider/Property;
public abstract fun getCommand ()Lorg/gradle/api/provider/Property;
public abstract fun getConfigFile ()Lorg/gradle/api/provider/Property;
public abstract fun getLogFormat ()Lorg/gradle/api/provider/Property;
public final fun getProperties ()Lkotlinx/rpc/buf/tasks/BufExecTask$Properties;
public abstract fun getWorkingDir ()Lorg/gradle/api/provider/Property;
}

public final class kotlinx/rpc/buf/tasks/BufExecTask$AndroidProperties : kotlinx/rpc/buf/tasks/BufExecTask$Properties {
public final fun getBuildType ()Ljava/lang/String;
public final fun getFlavor ()Ljava/lang/String;
public final fun getVariant ()Ljava/lang/String;
}

public class kotlinx/rpc/buf/tasks/BufExecTask$Properties {
public final fun getSourceSetName ()Ljava/lang/String;
public final fun isTest ()Z
}

public final class kotlinx/rpc/buf/tasks/BufExecTaskKt {
public static final fun registerBufExecTask (Lorg/gradle/api/Project;Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/provider/Provider;Lkotlin/jvm/functions/Function1;)Lorg/gradle/api/tasks/TaskProvider;
public static synthetic fun registerBufExecTask$default (Lorg/gradle/api/Project;Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/provider/Provider;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)Lorg/gradle/api/tasks/TaskProvider;
public static final fun registerBufExecTask (Lorg/gradle/api/Project;Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/provider/Provider;Lkotlinx/rpc/buf/tasks/BufExecTask$Properties;Lkotlin/jvm/functions/Function1;)Lorg/gradle/api/tasks/TaskProvider;
public static synthetic fun registerBufExecTask$default (Lorg/gradle/api/Project;Lkotlin/reflect/KClass;Ljava/lang/String;Lorg/gradle/api/provider/Provider;Lkotlinx/rpc/buf/tasks/BufExecTask$Properties;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)Lorg/gradle/api/tasks/TaskProvider;
}

public abstract class kotlinx/rpc/buf/tasks/BufGenerateTask : kotlinx/rpc/buf/tasks/BufExecTask {
public static final field NAME_PREFIX Ljava/lang/String;
public fun <init> ()V
public abstract fun getAdditionalArgs ()Lorg/gradle/api/provider/ListProperty;
public abstract fun getErrorFormat ()Lorg/gradle/api/provider/Property;
public abstract fun getExecutableFiles ()Lorg/gradle/api/provider/ListProperty;
Expand All @@ -133,28 +140,38 @@ public abstract class kotlinx/rpc/buf/tasks/BufGenerateTask : kotlinx/rpc/buf/ta
public abstract fun getOutputDirectory ()Lorg/gradle/api/provider/Property;
}

public abstract interface class kotlinx/rpc/buf/tasks/BufTasks : org/gradle/api/tasks/TaskCollection {
public abstract fun executedForKotlinSourceSet (Lorg/gradle/api/NamedDomainObjectProvider;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun executedForKotlinSourceSet (Lorg/jetbrains/kotlin/gradle/plugin/KotlinSourceSet;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun executedForSourceSet (Ljava/lang/String;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun executedForSourceSet (Lorg/gradle/api/NamedDomainObjectProvider;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun executedForSourceSet (Lorg/gradle/api/tasks/SourceSet;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingBuildType (Ljava/lang/String;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingFlavor (Ljava/lang/String;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingKotlinSourceSet (Lorg/gradle/api/NamedDomainObjectProvider;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingKotlinSourceSet (Lorg/jetbrains/kotlin/gradle/plugin/KotlinSourceSet;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingSourceSet (Ljava/lang/String;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingSourceSet (Lorg/gradle/api/NamedDomainObjectProvider;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingSourceSet (Lorg/gradle/api/tasks/SourceSet;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun matchingVariant (Ljava/lang/String;)Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun nonTestTasks ()Lkotlinx/rpc/buf/tasks/BufTasks;
public abstract fun testTasks ()Lkotlinx/rpc/buf/tasks/BufTasks;
}

public final class kotlinx/rpc/buf/tasks/BufTasksKt {
public static final fun bufDependsOn (Lkotlinx/rpc/buf/tasks/BufExecTask;Lkotlin/reflect/KClass;)Lkotlinx/rpc/buf/tasks/BufTasks;
}

public abstract class kotlinx/rpc/buf/tasks/GenerateBufGenYaml : org/gradle/api/DefaultTask {
public static final field NAME_PREFIX Ljava/lang/String;
public fun <init> ()V
public abstract fun getBufGenFile ()Lorg/gradle/api/provider/Property;
}

public final class kotlinx/rpc/buf/tasks/GenerateBufGenYamlKt$inlined$sam$i$org_gradle_api_Action$0 : org/gradle/api/Action {
public fun <init> (Lkotlin/jvm/functions/Function1;)V
public final synthetic fun execute (Ljava/lang/Object;)V
}

public abstract class kotlinx/rpc/buf/tasks/GenerateBufYaml : org/gradle/api/DefaultTask {
public static final field NAME_PREFIX Ljava/lang/String;
public fun <init> ()V
public abstract fun getBufFile ()Lorg/gradle/api/provider/Property;
}

public final class kotlinx/rpc/buf/tasks/GenerateBufYamlKt$inlined$sam$i$org_gradle_api_Action$0 : org/gradle/api/Action {
public fun <init> (Lkotlin/jvm/functions/Function1;)V
public final synthetic fun execute (Ljava/lang/Object;)V
}

public final class kotlinx/rpc/protoc/ConstsKt {
public static final field PROTOC_GEN_GRPC_KOTLIN_MULTIPLATFORM_JAR_CONFIGURATION Ljava/lang/String;
public static final field PROTOC_GEN_KOTLIN_MULTIPLATFORM_JAR_CONFIGURATION Ljava/lang/String;
Expand All @@ -166,6 +183,7 @@ public final class kotlinx/rpc/protoc/ConstsKt {
public static final field PROTO_GROUP Ljava/lang/String;
public static final field PROTO_SOURCE_DIRECTORY_NAME Ljava/lang/String;
public static final field PROTO_SOURCE_SETS Ljava/lang/String;
public static final field PROTO_SOURCE_SET_EXTENSION_NAME Ljava/lang/String;
}

public final class kotlinx/rpc/protoc/PluginJarsKt {
Expand All @@ -174,32 +192,41 @@ public final class kotlinx/rpc/protoc/PluginJarsKt {
}

public abstract class kotlinx/rpc/protoc/ProcessProtoFiles : org/gradle/api/tasks/Copy {
public fun <init> ()V
}

public final class kotlinx/rpc/protoc/ProcessProtoFilesKt$inlined$sam$i$org_gradle_api_Action$0 : org/gradle/api/Action {
public fun <init> (Lkotlin/jvm/functions/Function1;)V
public final synthetic fun execute (Ljava/lang/Object;)V
public abstract interface class kotlinx/rpc/protoc/ProtoSourceSet : org/gradle/api/file/SourceDirectorySet {
public abstract fun plugin (Lkotlinx/rpc/protoc/ProtocPlugin;Lorg/gradle/api/Action;)V
public abstract fun plugin (Lorg/gradle/api/Action;Lkotlin/jvm/functions/Function1;)V
public abstract fun plugin (Lorg/gradle/api/NamedDomainObjectProvider;Lorg/gradle/api/Action;)V
public abstract fun plugin (Lorg/gradle/api/provider/Provider;Lorg/gradle/api/Action;)V
public static synthetic fun plugin$default (Lkotlinx/rpc/protoc/ProtoSourceSet;Lkotlinx/rpc/protoc/ProtocPlugin;Lorg/gradle/api/Action;ILjava/lang/Object;)V
public static synthetic fun plugin$default (Lkotlinx/rpc/protoc/ProtoSourceSet;Lorg/gradle/api/Action;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)V
public static synthetic fun plugin$default (Lkotlinx/rpc/protoc/ProtoSourceSet;Lorg/gradle/api/NamedDomainObjectProvider;Lorg/gradle/api/Action;ILjava/lang/Object;)V
public static synthetic fun plugin$default (Lkotlinx/rpc/protoc/ProtoSourceSet;Lorg/gradle/api/provider/Provider;Lorg/gradle/api/Action;ILjava/lang/Object;)V
}

public abstract interface class kotlinx/rpc/protoc/ProtoSourceSet {
public abstract fun getName ()Ljava/lang/String;
public abstract fun getPlugins ()Lorg/gradle/api/NamedDomainObjectContainer;
public abstract fun getProto ()Lorg/gradle/api/file/SourceDirectorySet;
public abstract fun plugins (Lorg/gradle/api/Action;)V
public fun proto (Lorg/gradle/api/Action;)V
public final class kotlinx/rpc/protoc/ProtoSourceSetKt {
public static final fun getProto (Lorg/gradle/api/NamedDomainObjectProvider;)Lorg/gradle/api/provider/Provider;
public static final fun getProto (Lorg/gradle/api/tasks/SourceSet;)Lkotlinx/rpc/protoc/ProtoSourceSet;
public static final fun getProto (Lorg/jetbrains/kotlin/gradle/plugin/KotlinSourceSet;)Lkotlinx/rpc/protoc/ProtoSourceSet;
public static final fun proto (Lorg/gradle/api/NamedDomainObjectProvider;Lorg/gradle/api/Action;)V
public static final fun proto (Lorg/gradle/api/tasks/SourceSet;Lorg/gradle/api/Action;)V
public static final fun proto (Lorg/jetbrains/kotlin/gradle/plugin/KotlinSourceSet;Lorg/gradle/api/Action;)V
public static final fun proto_kotlin (Lorg/gradle/api/NamedDomainObjectProvider;)Lorg/gradle/api/provider/Provider;
public static final fun proto_kotlin (Lorg/gradle/api/NamedDomainObjectProvider;Lorg/gradle/api/Action;)V
}

public abstract interface class kotlinx/rpc/protoc/ProtocExtension {
public abstract fun buf (Lorg/gradle/api/Action;)V
public abstract fun getBuf ()Lkotlinx/rpc/buf/BufExtension;
public abstract fun getPlugins ()Lorg/gradle/api/NamedDomainObjectContainer;
public abstract fun plugins (Lorg/gradle/api/Action;)V
}

public class kotlinx/rpc/protoc/ProtocPlugin {
public static final field Companion Lkotlinx/rpc/protoc/ProtocPlugin$Companion;
public static final field GRPC_KOTLIN_MULTIPLATFORM Ljava/lang/String;
public static final field KOTLIN_MULTIPLATFORM Ljava/lang/String;
public fun <init> (Ljava/lang/String;Lorg/gradle/api/Project;)V
public final fun getArtifact ()Lorg/gradle/api/provider/Property;
public final fun getExcludeTypes ()Lorg/gradle/api/provider/ListProperty;
public final fun getIncludeImports ()Lorg/gradle/api/provider/Property;
Expand All @@ -217,7 +244,6 @@ public abstract class kotlinx/rpc/protoc/ProtocPlugin$Artifact {
}

public final class kotlinx/rpc/protoc/ProtocPlugin$Artifact$Local : kotlinx/rpc/protoc/ProtocPlugin$Artifact {
public fun <init> (Lorg/gradle/api/Project;)V
public final fun executor (Lorg/gradle/api/provider/Provider;)V
public final fun executor ([Ljava/lang/String;)V
public final fun getExecutableFiles ()Lorg/gradle/api/provider/ListProperty;
Expand All @@ -228,7 +254,6 @@ public final class kotlinx/rpc/protoc/ProtocPlugin$Artifact$Local : kotlinx/rpc/
}

public final class kotlinx/rpc/protoc/ProtocPlugin$Artifact$Remote : kotlinx/rpc/protoc/ProtocPlugin$Artifact {
public fun <init> (Lorg/gradle/api/Project;)V
public final fun getLocator ()Lorg/gradle/api/provider/Property;
}

Expand Down
6 changes: 1 addition & 5 deletions gradle-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
import util.other.generateSource

/*
* Copyright 2023-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
*/

plugins {
`kotlin-dsl`
alias(libs.plugins.conventions.jvm)
Expand All @@ -22,7 +18,7 @@ version = rootProject.libs.versions.kotlinx.rpc.get()
kotlin {
explicitApi()

jvmToolchain(11)
jvmToolchain(17)
}

tasks.withType<KotlinCompile>().configureEach {
Expand Down
53 changes: 44 additions & 9 deletions gradle-plugin/src/main/kotlin/kotlinx/rpc/Extensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ internal fun Project.rpcExtensionOrNull(): RpcExtension? = extensions.findByType
internal fun Project.rpcExtension(): RpcExtension = rpcExtensionOrNull()
?: error("Rpc extension not found. Please apply the plugin to the project")

public open class RpcExtension @Inject constructor(objects: ObjectFactory, private val project: Project) {
public open class RpcExtension @Inject internal constructor(objects: ObjectFactory, project: Project) {
/**
* Controls `@Rpc` [annotation type-safety](https://github.com/Kotlin/kotlinx-rpc/pull/240) compile-time checkers.
*
Expand All @@ -48,29 +48,64 @@ public open class RpcExtension @Inject constructor(objects: ObjectFactory, priva
configure.execute(strict)
}

internal val protocApplied = AtomicBoolean(false)

/**
* Protoc settings.
*
* Can't be called in a lazy context if not initialized.
*/
public val protoc: ProtocExtension by lazy {
if (protocApplied.get()) {
error("Illegal access to protoc extension during DefaultProtocExtension.init")
public val protoc: Provider<ProtocExtension> = project.provider {
if (!protocApplied.get()) {
error("""
Protoc extension was not initialized.
Please, apply the plugin by using the following declaration:

rpc {
protoc()
}

If the error persists, check if you are using this property lazily,
i.e. by calling 'protoc.map { }' and not 'protoc.get()',
otherwise the order of initialization may be wrong.
""".trimIndent())
}

protocApplied.set(true)
objects.newInstance<DefaultProtocExtension>()
protocInternal
}

/**
* Protoc settings.
*/
public fun protoc(configure: Action<ProtocExtension> = Action {}) {
configure.execute(protoc)
configure.execute(protocInternal)
}

internal val protocApplied = AtomicBoolean(false)

internal val protocInternal by lazy {
if (protocApplied.get()) {
error("Illegal access to protoc extension during DefaultProtocExtension.init")
}

protocApplied.set(true)
Comment on lines +86 to +90
Copy link
Collaborator

@Jozott00 Jozott00 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

if (protocApplied.getAndSet(true) { ... }

to make it actually thread safe

Copy link
Member Author

@Mr3zee Mr3zee Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you're right

objects.newInstance<DefaultProtocExtension>().apply {
callbacks.forEach { it.execute(this) }
}
}

private val callbacks = mutableListOf<Action<ProtocExtension>>()

internal fun whenProtocApplied(action: Action<ProtocExtension>) {
if (protocApplied.get()) {
action.execute(protoc.get())
return
}

callbacks.add(action)
}
}

public open class RpcStrictModeExtension @Inject constructor(objects: ObjectFactory) {
public open class RpcStrictModeExtension @Inject internal constructor(objects: ObjectFactory) {
/**
* `StateFlow`s in RPC services are deprecated,
* due to their error-prone nature.
Expand Down
Loading
Loading