Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional cache for login result and htpasswd + fixes #1668

Merged
merged 36 commits into from
Jan 3, 2025

Conversation

pbiering
Copy link
Collaborator

@pbiering pbiering commented Jan 3, 2025

  • Add: option [auth] cache_logins/cache_successful_logins_expiry/cache_failed_logins for caching logins
  • Add: option [auth] htpasswd_cache to automatic re-read triggered on change (mtime or size) instead reading on each request
  • Improve: [auth] log used hash method and result on debug for htpasswd authentication
  • Improve: [auth] htpasswd file now read and verified on start
  • Improve: [auth] htpasswd: module 'bcrypt' is no longer mandatory in case digest method not used in file
  • Improve: [auth] successful/failed login logs now type and whether result was taken from cache
  • Improve: [auth] constant execution time for failed logins independent of external backend or by htpasswd used digest method
  • Drop: support for Python 3.8

This should

Unfortunatly, this PR turned bigger and bigger somehow during development :-(

@pbiering pbiering added feature improvement auth:ldap Authentication LDAP auth auth:bcrypt Authentication bycrpt labels Jan 3, 2025
@pbiering pbiering added this to the 3.3.4 milestone Jan 3, 2025
@pbiering pbiering merged commit b0d56f8 into Kozea:master Jan 3, 2025
19 checks passed
@pbiering
Copy link
Collaborator Author

pbiering commented Jan 3, 2025

btw. tests are very welcome!

@pbiering pbiering deleted the login-cache branch January 27, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth:bcrypt Authentication bycrpt auth:ldap Authentication LDAP auth feature improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radicale quite slow after fresh installation with just one item in the calendar using bcrypt authentication
1 participant