fix: doctrine query parameter should not apply type when it wasn't sp…

…ecified explicitly
Kreyu · Mar 21, 2024 · 0d53e81 · 0d53e81
1 parent adaf7de
commit 0d53e81
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/src/Bridge/Doctrine/Orm/Filter/DoctrineOrmFilterHandler.php b/src/Bridge/Doctrine/Orm/Filter/DoctrineOrmFilterHandler.php
@@ -42,7 +42,11 @@ public function handle(ProxyQueryInterface $query, FilterData $data, FilterInter
         $queryBuilder = $query->getQueryBuilder();
 
         foreach ($event->getParameters() as $parameter) {
-            $queryBuilder->setParameter($parameter->getName(), $parameter->getValue(), $parameter->getType());
+            $queryBuilder->setParameter(
+                $parameter->getName(),
+                $parameter->getValue(),
+                $parameter->typeWasSpecified() ? $parameter->getType() : null,
+            );
         }
 
         $expression = $this->expressionFactory->create($query, $data, $filter, $event->getParameters());

diff --git a/tests/Unit/Bridge/Doctrine/Orm/Filter/DoctrineOrmFilterHandlerTest.php b/tests/Unit/Bridge/Doctrine/Orm/Filter/DoctrineOrmFilterHandlerTest.php
@@ -69,21 +69,38 @@ public function testItAppliesExpression(): void
         $this->createHandler(expression: 'expression')->handle($this->query, $this->data, $this->filter);
     }
 
-    public function testItSetsParameter(): void
+    public function testItSetsParameterWithoutTypeSpecified(): void
     {
         ($queryBuilder = $this->createQueryBuilderMock())
             ->expects($this->once())
             ->method('setParameter')
-            ->willReturnCallback(function ($name, $value) {
+            ->willReturnCallback(function ($name, $value, $type) {
                 $this->assertEquals('foo', $name);
                 $this->assertEquals('bar', $value);
+                $this->assertNull($type);
             });
 
         $this->query->method('getQueryBuilder')->willReturn($queryBuilder);
 
         $this->createHandler(parameters: [new Parameter('foo', 'bar')])->handle($this->query, $this->data, $this->filter);
     }
 
+    public function testItSetsParameterWithTypeSpecified()
+    {
+        ($queryBuilder = $this->createQueryBuilderMock())
+            ->expects($this->once())
+            ->method('setParameter')
+            ->willReturnCallback(function ($name, $value, $type) {
+                $this->assertEquals('foo', $name);
+                $this->assertEquals('bar', $value);
+                $this->assertEquals('date_immutable', $type);
+            });
+
+        $this->query->method('getQueryBuilder')->willReturn($queryBuilder);
+
+        $this->createHandler(parameters: [new Parameter('foo', 'bar', 'date_immutable')])->handle($this->query, $this->data, $this->filter);
+    }
+
     public function testItDispatchesEvents(): void
     {
         $this->eventDispatcher