Ignore null values, so it can be handled by another constraint

Kreyu · Nov 9, 2019 · c134efc · c134efc
1 parent 94b4e53
commit c134efc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Validator/Constraints/NipValidator.php b/src/Validator/Constraints/NipValidator.php
@@ -21,9 +21,15 @@ class NipValidator extends ConstraintValidator
 {
     /**
      * {@inheritDoc}
+     *
+     * @var Nip $constraint
      */
     public function validate($value, Constraint $constraint)
     {
+        if (null === $value) {
+            return;
+        }
+
         if (!preg_match($pattern = $this->getPattern($constraint), $value)) {
             $this->context->buildViolation($constraint->patternMessage)
                 ->setParameter('{{ value }}', $this->formatValue($value))

diff --git a/tests/Validator/Constraints/NipValidatorTest.php b/tests/Validator/Constraints/NipValidatorTest.php
@@ -348,6 +348,12 @@ public function testInvalidCustomPrefixLength($value)
             ->assertRaised();
     }
 
+    public function testNullValueIsIgnored()
+    {
+        $this->validator->validate(null, new Nip());
+        $this->assertNoViolation();
+    }
+
     public function testNipConstraintClassAlias()
     {
         $this->assertInstanceOf(Nip::class, new Tin());