Skip to content

Conversation

@MalefactorIX
Copy link
Contributor

@MalefactorIX MalefactorIX commented May 15, 2020

The anti-grief shown works against both large AND recursive damage sources without filling up the list with each individual hit. This is, obviously, slower and will more likely drops hits during high latency than the slim or directional variants BUT it should be very rare if not virtually impossible for it to stack-heap under stressful conditions. However since damage is still updated at the time of impact and instead of waiting on the timer event, it should overall perform better in a majority of situations.

Removed code that was used in the Directional version which now serves no function in slim
The anti-grief shown works against both large AND recursive damage sources without filling up the list with each individual hit. This is, obviously, slower and will more likely drops hits during high latency BUT it should be very rare if not virtually impossible for it to stack-heap under stressful conditions. However since damage is still updated at the time of impact and instead of waiting on the timer event, it should overall perform better in a majority of situations.
The intent is to grab the source's location with llDetectedPos during the collision event and using that as a reference. If no such reference exists, the system will just default to the current method. 

The goal is to clamp how the list is generated so it doesn't cause the system to stack-heap when exposed to many damage sources at a time. The eldest entries in the list will be dropped once it fills.
Now calculates and stores the modifier instead of the position. Removed a bunch of commands and otherwise unused code.
@HadetTheUndying
Copy link
Collaborator

As per Criss' report in Discord it appears that Damage Messages from things that don't collide with the Armored object are blocked. For Example

[11:57] [Chaos] Voss Pattern Lascannon v.1.17 : Delivering 25 AT to - Object
[11:57] Object: Damage Blocked by Armor
[11:57] Object: Attack was stopped by armor.

I'll try to Lint the code in a bit, but when it was initially reported I thought it was an issue with the merged 1.2.3. So I logged in to verify.

@HadetTheUndying
Copy link
Collaborator

I'll do a bit more testing on your fork on Saturday, and probably Merge on Monday.

I don't really see any issues, and I agree it might be time to consider reworking the existing Anti-Grief system in the core LBA.

@HadetTheUndying
Copy link
Collaborator

I'm gonna be testing this over the weekend. If you're satisfied that it's stable, I'll merge after testing.

@HadetTheUndying
Copy link
Collaborator

Are you ready for me to test this this week or do you think you're gonna make a ton more commits? Sorry it took me so long to get around to it dude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants