🔨 Fix pod template labels mutator 🔨

[eguzki]

What

When the existing deployment template label has few extra labels, the pod template label mutator was returning true to update the resource even when there was no update to be done. The extra few labels are preserved by the mutator. That apparently little issue of reporting "update" when it should not had secondary effects. The status controller would never set the status as Ready because it is being told that there is an update still going on.

Verifications steps

• Checkout this branch

• Run cluster

kind create cluster --name authorino-operator-system

• Install CRDs

make install

• Run operator locally

make run

• Create authorino object.

k apply -f - <<EOF
apiVersion: operator.authorino.kuadrant.io/v1beta1
kind: Authorino
metadata:
  name: authorino
spec:
  listener:
    tls:
      enabled: false
  oidcServer:
    tls:
      enabled: false
EOF

• Wait for authorino instance to be ready

kubectl wait --timeout=300s --for=condition=Ready authorino authorino

• Add manually few extra pod template labels

kubectl patch deployment authorino --type=merge --patch '{"spec": {"template": {"metadata": {"labels": {"foo": "bar", "foo2": "bar2"}}}}}'

• Wait for authorino instance to be ready

kubectl wait --timeout=300s --for=condition=Ready authorino authorino

If authorino CR gets the Ready condition in status, the fix worked. If trying out the same verification steps with current HEAD of main, the authorino status looks like this:

❯ k get authorino authorino -o jsonpath="{.status}" | yq e -P
conditions:
  - lastTransitionTime: "2025-04-14T17:19:18Z"
    message: Authorino Deployment resource updated
    reason: Updated
    status: "False"
    type: Ready

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (a5502a9) to head (86bdf7f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   63.74%   63.84%   +0.09%     
==========================================
  Files          14       15       +1     
  Lines        1553     1557       +4     
==========================================
+ Hits          990      994       +4     
  Misses        482      482              
  Partials       81       81              

Flag	Coverage Δ
unit	63.84% <100.00%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[maleck13]

nit: might be nice to add a quick comment so its known the bool returned is to let you know if the map was modified?

[eguzki]

done