Conversation
for future realisation of superblock also add superblock to the base bdev struct
- add raid metadata's magic number - add enum for the metadata versions - change uuid from base bdev to raid bdev - add physical blocklen
…superblock add position, is_new_ sb_loaded to raid_base_bdev_info is_new to raid_bdev for operation with raid's superblocks
…o raid_base_bdev_info
add memset 0 for remaining of superblock in super_sync
change enum to uint32_t remove useless phys_blocklen
for super_init_validation function
raid_bdev->is_new shouldn't be changed in this function super_sync will be in base_bdev_super_validate
remove rewrite of blockcnt, timestamp
rename to super_init_validation add validation of metadata add return
it's main function for operate with raid metadata during initialization
add spdk_bdev_read_blocks error return add free of io channel change message in read callback
delete useless ctx in load_base_bdevs_sb rename load_base_bdevs_sb to base_bdev_read_sb replace bad from bad to if base_bdev_read_sb
also fix typo in DEBUGLOGSs
…d_bdev_module_init function
change level type from uint32_t to int32_t fix pragma pack
make it static change level type from uint32_t to int32_t
also add DEBUGLOG
add strip_size_shift and blocklen_shift calculation to super_init_validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metadata to the raid module. Now it is possible to retrieve raid from base bdevs. Also add CLI interface for it in rpc.py.
Updating of metadata not implemented yet.