Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contribution guide with new Golang version and coverage requirements #581

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented Jan 3, 2025

Purpose:

  • Update required Golang version from 1.19+ to 1.22+
  • Adjust pull request coverage requirement from 70% to 60%

These changes ensure that the documentation reflects the current development environment requirements and project standards.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…requirements

- Update required Golang version from 1.19+ to 1.22+
- Adjust pull request coverage requirement from 70% to 60%

These changes ensure that the documentation reflects the current development environment requirements and project standards.
@elliotxx elliotxx requested a review from ruquanzhao January 3, 2025 14:56
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kusionstack 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 2:59am

Copy link
Contributor

@ruquanzhao ruquanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruquanzhao ruquanzhao merged commit 5357677 into main Jan 6, 2025
3 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants