Apply suggestions from code review

Co-authored-by: rianoc-kx <46995503+rianoc-kx@users.noreply.github.com>
KxSystems · Jan 17, 2024 · f9903e8 · f9903e8
1 parent 28214ad
commit f9903e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/pykx/pandas_api/pandas_meta.py b/src/pykx/pandas_api/pandas_meta.py
@@ -51,8 +51,8 @@ def _get_bool_only_subtable(tab):
 
 def preparse_computations(tab, axis=0, skipna=True, numeric_only=False, bool_only=False):
     if 'Keyed' in str(type(tab)):
-        tab = q('{(keys x) _ 0!x}', tab)
-    cols = q('cols', tab)
+        tab = tab.values()
+    cols = tab.columns
     if numeric_only:
         (tab, cols) = _get_numeric_only_subtable_with_bools(tab)
     if bool_only:

diff --git a/tests/test_pandas_api.py b/tests/test_pandas_api.py
@@ -1810,7 +1810,7 @@ def test_pandas_max(q):
     for i in range(100):
         assert float(qmax[i]) == float(pmax[i])
 
-    ktab = q('{1!x}', tab)
+    ktab = tab.set_index('sym')
     df = ktab.pd()
 
     qmax = ktab.max().py()