Relocation of part of the utilities from TrackingTypes.h (issue #30090) [1/3] #54

PetrilloAtWork · 2025-10-31T07:22:35Z

This is the proposed resolution of LArSoft issue #30090.

The utilities depending on lardataalg functionality have been relocated from lardataobj/Utilities/TrackingTypes.h to the new header lardataalg/Utilities/TrackingTypeUtils.h.
One unused utility function has been removed (convertVecPointToTVec3()).

Three pull requests are involved:

Relocation of part of the utilities from TrackingTypes.h (issue #30090) [1/3] #54 (this one) removing the functions with unacceptable dependencies;
Relocation of part of the utilities from TrackingTypes.h (issue #30090) [2/3] #54 lardataalg#53 where those functions are moved to;
Relocation of part of the utilities from TrackingTypes.h (issue #30090) [3/3] #54 larreco#88 for fixes consequent to the breaking change.

Conversion guide

This is technically a breaking change:

If your program needs one of the utilities which have not changed location, you don't need to do anything
- but the removal of larcorealg::Geometry dependency might expose an existing CMakeLists.txt bug, that may require the addition of larcorealg::Geometry in the LIBRARIES list of existing libraries as appropriate (or ROOT::Hist which was indirectly also provided).
If your program needs one of the relocated libraries:
1. inculsion of the header lardataalg/Utilities/TrackingTypeUtils.h needs to be added (rarely, it can legitimately replace TrackingTypes.h one);
2. the library lardataalg::UtilitiesHeaders needs to be added to the library link list (LIBRARIES, choosing PUBLIC/PRIVATE/INTERFACE according to the usual rules).
If your code needs recob::tracking::convertVecPointToTVec3(), report that need to LArSoft team since that function was deemed unused and therefore removed.

Pull requests have been opened in all LArSoft repositories where GitHub reports the usage of one of the functions (except toPoint()/toVector() which haven't been followed because of too many false positives).
Experiment code was not surveyed.

Part of TrackingTypes.h was moved to lardataalg. This is solution to LArSoft issue #30090.

FNALbuild · 2025-10-31T07:23:00Z

A new Pull Request was created by @PetrilloAtWork (Gianluca Petrillo) for develop.

It involves the following packages:

lardataobj

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

FNALbuild · 2025-10-31T07:23:00Z

The code-checks are being triggered in jenkins.

FNALbuild · 2025-10-31T07:23:11Z

+code-checks

lgarren · 2025-11-03T19:22:11Z

trigger build with pull requests #54, LArSoft/lardataalg#53, LArSoft/larreco#88

FNALbuild · 2025-11-03T19:22:36Z

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/lardataalg#53,LArSoft/larreco#88

FNALbuild · 2025-11-03T19:37:00Z

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28178&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-11-03T19:37:02Z

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28178&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-11-03T19:40:20Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28179&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-11-03T19:40:21Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28179&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-11-03T19:46:15Z

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/18892&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-11-03T19:46:17Z

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/18892&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-11-03T19:46:35Z

-ICARUS tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13335&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-11-03T19:46:37Z

-ICARUS tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13335&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-11-03T19:46:55Z

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12970&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-11-03T19:46:56Z

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12970&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-11-03T19:53:00Z

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/20296&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28178&builds=

FNALbuild · 2025-12-01T16:43:00Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28606&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-12-01T16:43:02Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28606&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

lgarren · 2025-12-02T00:04:18Z

trigger build with pull requests #54, LArSoft/lardataalg#53, LArSoft/larreco#88, DUNE/duneprototypes#97, DUNE/dunereco#167, DUNE/dunesim#101, DUNE/protoduneana#66, uboone/ubana#74, uboone/ublite#3, uboone/ubreco#34, uboone/ubevt#4, uboone/ubcore#4, SBNSoftware/sbndcode#880

FNALbuild · 2025-12-02T00:04:43Z

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/lardataalg#53,LArSoft/larreco#88,DUNE/duneprototypes#97,DUNE/dunereco#167,DUNE/dunesim#101,DUNE/protoduneana#66,uboone/ubana#74,uboone/ublite#3,uboone/ubreco#34,uboone/ubevt#4,uboone/ubcore#4,SBNSoftware/sbndcode#880

FNALbuild · 2025-12-02T00:18:46Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28608&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-12-02T00:18:48Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28608&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-12-02T00:20:37Z

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28607&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-12-02T00:20:38Z

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28607&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-12-02T00:30:11Z

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/13086&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:30:13Z

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/13086&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:47:21Z

-SBND tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/19349&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:47:22Z

-SBND tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/19349&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:51:47Z

-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13588&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:51:49Z

-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13588&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:56:52Z

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/20412&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

FNALbuild · 2025-12-02T00:56:53Z

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/20412&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28607&builds=

lgarren · 2025-12-02T21:59:32Z

approve

FNALbuild · 2025-12-03T23:05:32Z

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

PetrilloAtWork added 2 commits October 30, 2025 18:48

Removed dependency on lardataalg from lardataobj

9ecb702

Part of TrackingTypes.h was moved to lardataalg. This is solution to LArSoft issue #30090.

The curious result of format-code

a8da850

FNALbuild added L1-pending code-checks-pending L2-pending signatures-pending tests-pending labels Oct 31, 2025

FNALbuild added code-checks-approved and removed code-checks-pending labels Oct 31, 2025

This was referenced Oct 31, 2025

Relocation of part of the utilities from TrackingTypes.h (issue #30090) [2/3] #54 LArSoft/lardataalg#53

Merged

Relocation of part of the utilities from TrackingTypes.h (issue #30090) [3/3] #54 LArSoft/larreco#88

Merged

lgarren added this to LArSoft pull requests Oct 31, 2025

lgarren moved this to Awaiting triage in LArSoft pull requests Oct 31, 2025

knoepfel moved this from Awaiting triage to Approval in progress in LArSoft pull requests Nov 3, 2025

FNALbuild added L2-approved L1-approved tests-started fully-signed and removed L1-pending L2-pending signatures-pending tests-pending labels Dec 3, 2025

lgarren moved this from Approval in progress to Approved and pending inclusion in release in LArSoft pull requests Dec 3, 2025

lgarren merged commit 71d3bdb into LArSoft:develop Dec 11, 2025
1 check passed

github-project-automation bot moved this from Approved and pending inclusion in release to Merged into develop in LArSoft pull requests Dec 11, 2025

lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Dec 11, 2025

Relocation of part of the utilities from TrackingTypes.h (issue #30090) [1/3] #54

Relocation of part of the utilities from TrackingTypes.h (issue #30090) [1/3] #54

Uh oh!

Conversation

PetrilloAtWork commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conversion guide

Uh oh!

FNALbuild commented Oct 31, 2025

Uh oh!

FNALbuild commented Oct 31, 2025

Uh oh!

FNALbuild commented Oct 31, 2025

Uh oh!

lgarren commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Nov 3, 2025

Uh oh!

FNALbuild commented Dec 1, 2025

Uh oh!

FNALbuild commented Dec 1, 2025

Uh oh!

lgarren commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 2, 2025

Uh oh!

lgarren commented Dec 2, 2025

Uh oh!

FNALbuild commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

PetrilloAtWork commented Oct 31, 2025 •

edited

Loading