-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
44 45 dependency update #46
Conversation
I got this error when I tried to install this branch as I used Python 3.8. Do we use Python 3.9 for generic tools? |
I hadn't thought of this, the environment I was testing in was 3.9. Python 3.8 is about to become completely unsupported in a few months so maybe this is a chance to require at least python 3.9 as well? Since we're already expecting generic tools to have to update to accommodate newer pandas, maybe it makes sense to expect them to accommodate newer python too. Let me know what you think |
I tested it in Python 3.9, encountered a few issues, and am currently fixing them for one of the generic tools. I agree with you on upgrading to Python 3.9, and Milica also thinks it's better to upgrade before 3.8 is deprecated. |
This is a minor version increment to:
pandas≥2.2.0
dependencysqlalchemy≥2.0.0
dependency, based on minimum pandas2.2.0 requirementopenpyxl≥3.1.2
dependency, based on the minimum pandas2.2.0 requirement that will allowto_python
to work as written hereThe idea is that this new version of adapter can be used to test
pandas≥2.2.0
compatibility updates to our tools, which can "jump" to this newer version after having updated relevant code to accommodatepandas≥2.2.0
.I tested this in a brand new environment by just installing dependencies as listed here and the tests still pass. I did have to deal with a tkinter issue (resolved here, completely outside of python dependencies controllable in this repo)
This PR would take precedence over this one from last year, just because it's updating all the dependencies together