Skip to content

Commit

Permalink
Merge pull request #33 from LBNL-ETA/update-eprad
Browse files Browse the repository at this point in the history
Update eprad
  • Loading branch information
taoning authored Sep 9, 2023
2 parents ec52194 + f9a5003 commit e6998c2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
11 changes: 5 additions & 6 deletions frads/eprad.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ def floors(self):
return floors

@property
def lighting_zones(self):
def lights(self):
"""
Example:
>>> model.lighting_zones
>>> model.lights
"""
if "Lights" in self.epjs:
return list(self.epjs["Lights"].keys())
Expand Down Expand Up @@ -763,7 +763,6 @@ def run(
output_directory: Optional[str] = "./",
output_prefix: Optional[str] = "eplus",
output_suffix: Optional[str] = "L",
weather_file: Optional[str] = None,
silent: bool = False,
annual: bool = False,
design_day: bool = False,
Expand All @@ -787,8 +786,8 @@ def run(
"""
opt = ["-d", output_directory, "-p", output_prefix, "-s", output_suffix]

if weather_file is not None:
opt.extend(["-w", weather_file])
if self.epw is not None:
opt.extend(["-w", self.epw])
elif design_day:
if "SizingPeriod:DesignDay" in self.epjs:
opt.append("-D")
Expand All @@ -804,7 +803,7 @@ def run(
)

if annual:
if weather_file is not None:
if self.epw is not None:
opt.append("-a")
else:
raise ValueError(
Expand Down
2 changes: 1 addition & 1 deletion test/test_eprad.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_energyplusmodel():
assert isinstance(epmodel.zones, list)
assert isinstance(epmodel.window_walls, list)
assert isinstance(epmodel.windows, list)
assert isinstance(epmodel.lighting_zones, list)
assert isinstance(epmodel.lights, list)
assert isinstance(epmodel.complex_fenestration_states, list)


Expand Down

0 comments on commit e6998c2

Please sign in to comment.