-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resimulation producer #1183
Resimulation producer #1183
Conversation
@EinarElen and I agreed to "hijack" this PR to do some code cleanup and reformatting within SimCore. While the newly introduced ReSimulator is not being tested by these PR Validations - it is helpful to make sure that the broad formatting/refactoring did not change any of the physics. I am not expecting it to since I trust clang to be helpful in this respect, but it is good to double check. |
I am getting a python-config error from the DQM module when trying to rerun the validation:
Maybe there is an issue with some of the updates you made when writing the DQM resim verifier? I'll leave this to your tomorrow (my tonight) and come back at it tomorrow (mine). |
Hmm, I would more suspect me messing up a rebase here. I'll have a look. |
The |
we can clean up this commit history using a quick rebase before merging
I used my god-like power to add Unfortunately, it appears like GitHub is not registering that run as associated with this PR which is unfortunate. |
Looks like the validation passed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me - a bit worried about conflicts coming from me editing the pr_validation workflow on trunk and this branch but that will be easy for me to patch mid-merge.
(I ended up just doing a non-rebase merge locally
) |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves LDMX-Software/SimCore#49 by adding a new producer that re-simulates events based on the seeds stored in the input file.
Check List
I successfully compiled ldmx-sw with my developments
I ran my developments and the following shows that they are successful.
I've added an analyzer in the DQM module that compares the sim hits and particles between two passes and tested it with an ecalPN configuration.
Related Sub-Module PRs
If you have developments in a submodule that you need to merge in along with these developments, please link those PRs here, otherwise just delete this section.
Note: You do not need to make a Sub-Module PR if your submodule developments are already on that repo's default branch.