Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix narrowing conversions #1207

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix narrowing conversions #1207

merged 2 commits into from
Sep 18, 2023

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 15, 2023

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1199

Check List

  • I successfully compiled ldmx-sw with my developments

  • I ran my developments and the following shows that they are successful.

The warning msg-s are gone.

  • I attached any sub-module related changes to this PR.

N/A

@tvami tvami changed the title Iss1199 Fix narrowing conversions Sep 15, 2023
@EinarElen EinarElen mentioned this pull request Sep 18, 2023
18 tasks
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The runtime logs look stable and the compile time logs do not show the warnings for these anymore :)

@tomeichlersmith tomeichlersmith merged commit b591c22 into trunk Sep 18, 2023
6 checks passed
@tomeichlersmith tomeichlersmith deleted the iss1199 branch September 18, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narrowing conversion warnings by the compiler
3 participants