Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up class versions for HcalHit, TestBeamHit, TrigScintHit #1429

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Bump up class versions for HcalHit, TestBeamHit, TrigScintHit #1429

merged 1 commit into from
Sep 3, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 2, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1427

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

I can now run

ldmx recompFire TrigScint/exampleConfigs/runQIEDecode.py /fs/ddn/sdf/group/ldmx/data/TS-data/test_stand_data/rootFiles/unpacked_ldmx_captan_out_09-04-2022_09-36-04__75_reformat_30timeSamplesFrom0_linearize_hits_clusters.root out.root raw 1 TrigScint/data/channelMap_LYSOback_plasticFront_12-to-16channels_rotated180.txt

w/o any issues

@tvami tvami mentioned this pull request Sep 2, 2024
Merged
2 tasks
@tvami tvami added trigscint topics pertaining to trigger scintillator simulation and analysis development hcal labels Sep 2, 2024
@tvami tvami merged commit 5041f33 into trunk Sep 3, 2024
5 of 10 checks passed
@tvami tvami deleted the iss1427-bumpup-hit-class-versions branch September 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyi211 danyi211 danyi211 approved these changes

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

@bryngemark bryngemark Awaiting requested review from bryngemark

@EinarElen EinarElen Awaiting requested review from EinarElen

Assignees
No one assigned
Labels
hcal trigscint topics pertaining to trigger scintillator simulation and analysis development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to bump up HcalHit, TrigScintHit and TestBeamHit streamer versions
3 participants
@tvami @tomeichlersmith @danyi211