Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing defaults in CalorimeterHit.h #1434

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add missing defaults in CalorimeterHit.h #1434

merged 1 commit into from
Sep 4, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 4, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Part of #1166

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

@tvami tvami mentioned this pull request Sep 4, 2024
Closed
7 tasks
@tvami tvami merged commit d7392d6 into trunk Sep 4, 2024
4 of 10 checks passed
@tvami tvami deleted the iss1166-hit-defaults branch September 4, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

@EinarElen EinarElen EinarElen approved these changes

@danyi211 danyi211 Awaiting requested review from danyi211

Assignees
No one assigned
Labels
bug cleanup ecal hcal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvami @EinarElen @tomeichlersmith