Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation installation to the just commands and rename the dir #1441

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Add validation installation to the just commands and rename the dir #1441

merged 2 commits into from
Sep 6, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 6, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1439

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.
just install-validation

installs Validation module
and then

cd Validation/src
denv python3 -m Validate -h

works, and then

denv python3 -m Validate compareDir/ --systems ecal.shower_feats

makes nice plots.

tomeichlersmith
tomeichlersmith reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only other broad comment is to update the Validation/README.md to avoid references to ldmx. I forgot to update it when merging denv+just and so now is the time. I can do that if you don't want to as well.

Validation/README.md Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@tvami tvami merged commit 6e8949c into trunk Sep 6, 2024
2 checks passed
@tvami tvami deleted the iss1439-validation-just branch September 6, 2024 15:25
tvami added a commit that referenced this pull request Sep 6, 2024
@tvami
Add more features to ECAL DQM & validation module (#1440)
f942699 
### What are the issues that this addresses?
Resolves #1398

 * added num of hits and noise hits into digi_verify DQM
 * added BDT score and if the recoil ele is fiducial in veto_results DQM
 * propagated all this to Validation module 

All the new histos in the histo.root file created by the CI config look
as they should tho!
The validation module works too, tho I had to make the changes as in
#1441
```
denv python3 -m Validation compareDir/ --systems ecal.digi_verify
denv python3 -m Validation compareDir/  --systems ecal.mip_tracking
denv python3 -m Validation compareDir/  --systems ecal.veto_results
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyi211 danyi211 danyi211 approved these changes

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

Assignees
No one assigned
Labels
validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation installation to the just commands & rename the dir
3 participants
@tvami @tomeichlersmith @danyi211