Add fiducial & BDT score cut options to EcalPreselectionSkimmer #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok this is due to the fact that now we see the staff supposed to be in the log(disc) plots, all good! |
tomeichlersmith
approved these changes
Sep 16, 2024
danyi211
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1449
Check List
I ran this on a file that has non-fiducial events only, when requiring non-fiducial events, all pass, when requiring fiducial events, none pass. Also it happened to be that there is 1 event that's has a BDT score higher than 0.99 so I skimmed for that too, and found 1 event yaay.