Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dereference boost.log's attribute pointer only if defined #1463

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tomeichlersmith
Copy link
Member

@tomeichlersmith tomeichlersmith commented Sep 17, 2024

this avoids clang-tidy complaining about de-referencing nullptrs since
there is a possibility the logs will contain messages that don't have a
Channel and/or Severity attribute

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

this avoids clang-tidy complaining about de-referencing nullptrs since
there is a possibility the logs will contain messages that don't have a
Channel and/or Severity attribute
@tvami
Copy link
Member

tvami commented Sep 17, 2024

Let me link this to being the follow-up to #1458

@tomeichlersmith
Copy link
Member Author

Running a more strict build locally to align with #1462

just clean
just configure-force-error
just build $(nproc) test

... taking a long time since my tiny computer is tiny ...

Copy link
Member

@tvami tvami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix for this! I checked that it works with the compiler and also tested the functionality. All good!

@tomeichlersmith tomeichlersmith merged commit bbd14eb into trunk Sep 17, 2024
2 checks passed
@tomeichlersmith tomeichlersmith deleted the log-safely branch September 17, 2024 19:19
tomeichlersmith added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants