Add back all_dqm in the ecal validation config #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it changes gold, I propose to merge this when the software is ready for a new gold anyway. In that period we can rely on the kaon validation to look at these plots missing in the gold |
tomeichlersmith
approved these changes
Sep 26, 2024
danyi211
approved these changes
Sep 26, 2024
tvami
force-pushed
the
all-dqm-in-ecal-val
branch
from
59ea7d5
to
62706b8
Compare
|
OK now the tests should be all fine, when they finish I'll merge this. Then we should merge the ASAN update and also the PRs from Rory and have a new patch release. |
|
OK I'm happy now with the test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
I concentrated so much on tracking in #1462 that I forgot the rest... upsie, sorry!
I'm adding it back now.
Check List