Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: retrieve and decode _into APIs #136

Merged
merged 21 commits into from
Jan 21, 2025
Merged

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jan 19, 2025

No description provided.

@LDeakin LDeakin added the breaking-changes The PR has API changes label Jan 19, 2025
@LDeakin LDeakin added this to the zarrs 0.20 milestone Jan 19, 2025
Base automatically changed from refactor_codec_errors to main January 19, 2025 05:22
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 91.51625% with 47 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (f675f06) to head (9bd09fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarrs/src/array/codec.rs 46.42% 15 Missing ⚠️
...s/src/array/codec/array_partial_encoder_default.rs 0.00% 7 Missing ⚠️
...ay/codec/array_to_array_partial_encoder_default.rs 0.00% 7 Missing ⚠️
zarrs/src/array/array_bytes.rs 91.89% 6 Missing ⚠️
zarrs/src/array/array_bytes_fixed_disjoint_view.rs 97.75% 5 Missing ⚠️
...ay/codec/array_to_bytes/sharding/sharding_codec.rs 91.37% 5 Missing ⚠️
zarrs/src/array/array_sync_readable.rs 96.00% 1 Missing ⚠️
...arrs/src/array/codec/array_to_bytes/codec_chain.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   81.93%   81.90%   -0.03%     
==========================================
  Files         171      172       +1     
  Lines       24268    24340      +72     
==========================================
+ Hits        19883    19935      +52     
- Misses       4385     4405      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin marked this pull request as ready for review January 19, 2025 21:21
@flying-sheep
Copy link

Really cool, that makes all of zarrs-python’s use almost safe.

there we take items from python and convert them into (non-overlapping) chunk_item::WithSubsets, so we can just add checks to that conversion so the checking is next to the unsafe code.

or we could move this use case to zarrs, seems like a thing people would like to do.

@LDeakin LDeakin merged commit 091019b into main Jan 21, 2025
22 checks passed
@LDeakin LDeakin deleted the refactor_decode_into branch January 21, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes The PR has API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants