-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wm container feature #1225
Open
pro470
wants to merge
46
commits into
LGUG2Z:master
Choose a base branch
from
pro470:wm-container-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wm container feature #1225
+683
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now need to discuss and maybe change that
This commit adds an optional --komorebi-config flag to the check command to allow users to check a komorebi.json file in an arbitrary location.
This commit adds support for specifying a layout flip axis for each workspace in the static configuration file.
…container not the window itself and also fixed formating
This commit adds mutex lock scoping in WindowManager::enforce_workspace_rule to avoid a deadlock when should_update_focused_workspace evaluates to true. fix LGUG2Z#1212
If a user triggers the workspace reconciliator by clicking on an app in the start bar or via alt-tab, a notification should be sent to subscribers such as komorebi-bar so that the focused workspace can be updated. The various komorebi reconciliators and manager modules don't emit events to subscribers themselves (yet?), so for now we can pass on the uncloak event. Maybe we can look into expanding the Notification enum in the future. fix LGUG2Z#1211
This commit adds a new komorebic command "stackbar-mode" to allow users to change stackbar modes programmatically.
…indow restoration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR about the idea I had of having something between Container and Workspace, but we don't. What I did is to make the Container more capable, a container has its own layout. So what did we break the answer is nothing everything is working I obviously didn't test all commands, but the important ones were tested, and it all worked. With that, we could have something between container and workspace but in the end, it is just a fancier container.
Pros:
Cons:
yeah, I think it is
I only have some things to discuss
I don't think this code is at your level so you have three options:
Anyway, see this code as a proof of concept and not like a real PR if I should then do something else then opening the PR. I don't know like opening a discussion or so. You need to tell me.
I didn't implement the commands because I don't know if you like to change how something works this would also change some command's behavior.
Yeah, that's it.