Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woptim] Update Shared CI and Spack Configs #255

Closed
wants to merge 8 commits into from

Conversation

adrienbernede
Copy link
Member

@adrienbernede adrienbernede commented Apr 15, 2024

Summary

  • This PR updates the Shared CI
  • This PR updates the submodule RADIUSS Spack Configs

Purpose

In Shared CI:

  • Fix reproducer to print needed environment variables

In RADIUSS Spack Configs:

  • The local CARE package has been removed, now using the one in RADIUSS Spack Configs.
  • The compilers (wrappers) on Lassen have been updated to better support the use of gcc 8.3.1 toolchain.
  • The local spack packages have been updated to be as close as possible to what we are pushing in RADIUSS packages update (Starting over #39613) spack/spack#41375.
  • We moved to Spack environments.

Notes

Packages in RADIUSS Spack Configs still have some specific changes compared to the PR mentioned above.

- Use spack environments
- Share CARE package, remove local copy
- Use compilers wrappers on lassen
- Update Uberenv
@adrienbernede adrienbernede changed the title [Woptim] [WIP] Update Shared CI and Spack Configs [Woptim] Update Shared CI and Spack Configs Apr 19, 2024
@adrienbernede
Copy link
Member Author

@adayton1 this is ready for review !

@@ -1,2 +0,0 @@
repo:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather this machinery be left in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

"spack_activate": {},
"spack_configs_path": "scripts/radiuss-spack-configs",
"spack_packages_path": ["scripts/radiuss-spack-configs/packages", "scripts/spack_packages/packages"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this machinery left in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@adrienbernede
Copy link
Member Author

@adayton1 sorry for the delay... I lost sight of it.

@adayton1
Copy link
Member

adayton1 commented Jun 5, 2024

@adayton1 sorry for the delay... I lost sight of it.

No worries! Is this one completely superseded by #263 ?

@adrienbernede
Copy link
Member Author

Closing, superseded by #263.
(@adayton1 I forgot to get this one first, but #263 had the full history, so we are good).

@adrienbernede adrienbernede deleted the woptim/spack-envs branch June 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants