Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunked/batched forall loops #262

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Add chunked/batched forall loops #262

merged 2 commits into from
Jun 4, 2024

Conversation

liu15
Copy link
Collaborator

@liu15 liu15 commented May 31, 2024

No description provided.

@liu15 liu15 requested review from adayton1 and dtaller May 31, 2024 17:33
@dtaller
Copy link
Collaborator

dtaller commented Jun 4, 2024

Should you add a few care tests that exercise this feature?

Besides that everyothing looks good, thanks!

Copy link
Collaborator

@dtaller dtaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! Looks good. Approved

Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 merged commit 77d8d7e into develop Jun 4, 2024
12 checks passed
@adayton1 adayton1 deleted the chunked branch June 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants