Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequential IntersectArrays for host_device_ptr arguments #282

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

liu15
Copy link
Collaborator

@liu15 liu15 commented Aug 19, 2024

This ensures that allocations are consistent - especially for thin GPU allocations

…allocations are consistent - especially for thin GPU allocations)
@liu15 liu15 requested review from robinson96 and adayton1 August 19, 2024 15:58
src/care/algorithm_impl.h Outdated Show resolved Hide resolved
Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1
Copy link
Member

Can you also clean up the title and description of the merge request?

@adayton1 adayton1 changed the title Fix sequential IntersectArrays for host_device_ptr arguments (ensure … Fix sequential IntersectArrays for host_device_ptr arguments Aug 19, 2024
Copy link
Collaborator

@robinson96 robinson96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 merged commit fbb3bd7 into develop Aug 20, 2024
12 checks passed
@adayton1 adayton1 deleted the intersectFix branch August 20, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants